Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate reply dispatch (#429) #436

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Sep 6, 2024

No description provided.

@jawoznia jawoznia force-pushed the jawoznia/feat/reply_dispatch branch from 1212a85 to 28914bc Compare September 10, 2024 16:17
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 78.24074% with 47 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (f08901a) to head (90a4a9a).
Report is 3 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/contract/communication/reply.rs 88.52% 14 Missing ⚠️
sylvia/tests/reply_generation.rs 0.00% 14 Missing ⚠️
sylvia-derive/src/entry_points.rs 0.00% 6 Missing ⚠️
sylvia-derive/src/contract/mt.rs 58.33% 5 Missing ⚠️
sylvia-derive/src/parser/attributes/msg.rs 58.33% 5 Missing ⚠️
sylvia-derive/src/contract.rs 80.00% 1 Missing ⚠️
sylvia/src/multitest.rs 83.33% 1 Missing ⚠️
sylvia/tests/reply.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #436      +/-   ##
================================================
+ Coverage         70.15%   71.23%   +1.08%     
================================================
  Files                55       54       -1     
  Lines              3156     3299     +143     
================================================
+ Hits               2214     2350     +136     
- Misses              942      949       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia changed the title feat!: Generate reply dispatch (#429) feat: Generate reply dispatch (#429) Sep 10, 2024
@jawoznia jawoznia force-pushed the jawoznia/feat/reply_dispatch branch 4 times, most recently from b29ccb8 to aab99a3 Compare September 12, 2024 10:54
@jawoznia jawoznia marked this pull request as ready for review September 12, 2024 10:54
@jawoznia jawoznia force-pushed the jawoznia/feat/reply_dispatch branch from aab99a3 to a0d7553 Compare September 13, 2024 14:43
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting! It introduces some tough logic, but it makes sense overall.

sylvia/tests/reply_generation.rs Show resolved Hide resolved
sylvia-derive/src/contract/communication/reply.rs Outdated Show resolved Hide resolved
sylvia-derive/src/contract/communication/reply.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the jawoznia/feat/generate_reply_id branch from c63c382 to 64daae9 Compare September 17, 2024 12:38
Base automatically changed from jawoznia/feat/generate_reply_id to feat/replies September 17, 2024 13:34
@jawoznia jawoznia force-pushed the jawoznia/feat/reply_dispatch branch from a0d7553 to c3f2c93 Compare September 18, 2024 10:30
Since this change would be breaking it's hidden behind `sv_replies`
feature flag.
@jawoznia jawoznia force-pushed the jawoznia/feat/reply_dispatch branch from c3f2c93 to 2af6f59 Compare September 18, 2024 10:31
@jawoznia jawoznia merged commit 72ebc77 into feat/replies Sep 19, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/reply_dispatch branch September 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants